Added ability for an inner folder name of a zip to be specified. #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeesonjohnson
commented
Jan 11, 2021
Comment on lines
+120
to
+141
| //Had to do the below, since otherwise the file did not zip in enough time. | ||
| function customZippingFunction(options, customFilePath) { | ||
| return new Promise((resolve, reject) => { | ||
| zipDir( | ||
| customFilePath || sampleZipPath, | ||
| options, | ||
| async function (err, buffer) { | ||
| if (err) { | ||
| reject(err); | ||
| return; | ||
| } | ||
| await fs | ||
| .createReadStream(xpiPath) | ||
| .pipe(unzip.Extract({ path: outputPath })) | ||
| .on("entry", (entry) => entry.autodrain()) | ||
| .promise() | ||
| .then(() => resolve()) | ||
| .catch(e=>reject(e)); | ||
| } | ||
| ); | ||
| }); | ||
| } |
Author
There was a problem hiding this comment.
Had to wrap the zipping command into its own promise since it was being flaky when running tests, since the zipping often took way too long, and zipDir cannot directly be awaited.
jeesonjohnson
commented
Jan 11, 2021
Comment on lines
+106
to
+118
| function customCompareMethod(file, customFilePath = "", combineCustomFilePathOrReplace = true) { | ||
| const zipBuffer = fs.readFileSync(path.join(sampleZipPath, file)); | ||
| const combinedFilePath = path.join(customFilePath, file); | ||
| // Compare the different file buffers. | ||
| const fileBuffer = fs.readFileSync( | ||
| path.join( | ||
| outputPath, | ||
| combineCustomFilePathOrReplace ? combinedFilePath : customFilePath | ||
| ) | ||
| ); | ||
|
|
||
| expect(bufferEqual(zipBuffer, fileBuffer)).to.be.ok; | ||
| } |
Author
There was a problem hiding this comment.
I can move the this function to the global def, but thought i would ask before changing the other aspects. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to define the name of the inner folder of the zip generated. A relevant issue can be found HERE.